fix: resolve focus and performance issues with file mentions in first message (#4127) #6180

MuriloFP · 2025-07-24T19:35:38Z

Related GitHub Issue

Closes: #4127

Roo Code Task Context (Optional)

No Roo Code task context for this PR

Description

This PR implements a 3-message synthetic context generation pattern to resolve focus and performance issues when file mentions (@filename) are used in the first user message.

Key implementation details:

Added extractFileMentions utility to detect and extract file paths from @ mentions
Modified Task.initiateTaskLoop to intercept first messages containing file mentions
Created handleFirstMessageWithFileMentions method that generates the synthetic message pattern:
1. Original user message (stored in task history without embedded content)
2. Synthetic assistant message with <read_file> tool calls
3. User message with the actual file contents
The task history (say method) only sees the clean original message, preventing UI performance degradation
The API conversation gets the proper context in the correct order, preventing model focus issues

Test Procedure

Automated Testing:

Added unit tests for extractFileMentions utility:

cd src && npx vitest run core/mentions/__tests__/extractFileMentions.spec.ts

Added integration tests for Task class to verify the 3-message pattern generation:
```
cd src && npx vitest run core/task/__tests__/Task.spec.ts
```

Manual Testing:

Build and run the extension
Start a new task with a file mention: @src/index.ts explain this file
Verify that:
- The task history shows only the original message without embedded content
- The model receives the file content in the proper context order
- The UI remains responsive even with large files

Pre-Submission Checklist

Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
Scope: My changes are focused on the linked issue (one major feature/fix per PR).
Self-Review: I have performed a thorough self-review of my code.
Testing: New and/or updated tests have been added to cover my changes (if applicable).
Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

No UI changes in this PR

Documentation Updates

No documentation updates are required.

Additional Notes

This implementation ensures backward compatibility - tasks without file mentions in the first message continue to work exactly as before. The synthetic message pattern is only generated when needed.

Get in Touch

Discord username not provided

Important

Introduces a synthetic message pattern to handle file mentions in the first message, improving focus and performance.

Behavior:
- Implements a 3-message synthetic context pattern in Task.ts to handle file mentions in the first message.
- Adds extractFileMentions utility in extractFileMentions.ts to detect file paths from @ mentions.
- Modifies Task.initiateTaskLoop to intercept first messages with file mentions.
- Introduces handleFirstMessageWithFileMentions in synthetic-messages.ts to generate synthetic messages.
Testing:
- Adds unit tests for extractFileMentions in extractFileMentions.spec.ts.
- Adds integration tests for Task class in Task.spec.ts to verify synthetic message pattern.
Misc:
- Updates parseMentions in index.ts to simplify file mention handling.

^{This description was created by}^{for c59edca. You can customize this summary. It will automatically update as commits are pushed.}

… message (RooCodeInc#4127) - Implement 3-message synthetic context generation pattern - Original user message stored without embedded file content in task history - Synthetic assistant message with read_file tool calls generated - File contents processed and added as separate user response - Prevents model focus degradation and UI performance issues - Add comprehensive tests for the new functionality

- Remove 'processed:' prefix from parseMentions mock - Update test expectations to match new behavior - Fix processUserContentMentions mock usage

KJ7LNW

in addition to the comment below:

we no longer need to modify the first message since you are injecting it in the rest of the body.

I do not remember where that is somewhere it changes @mention to @mention (see file below) or something like that.

this pull request makes it possible for the first message to arrive and modified.

it was not clear to me whether or not the task.ts changes trigger to start after modifying the context: it would be a good idea to manually verify that when you create the mention that the task loads the files and continues without user intervention

src/core/task/Task.ts

- Fixed failing unit tests by properly mocking extractFileMentions and hasFileMentions - Removed 'see below for file content' text from file mentions as requested in PR review - Updated all related test expectations to match the new behavior - Ensured task continues automatically after synthetic message handling

- Moved shouldUseSyntheticMessages, handleFirstMessageWithFileMentions, and createSyntheticReadFileMessage to new synthetic-messages.ts module - Made addToApiConversationHistory public to allow access from the new module - Updated imports and function calls in Task.ts - Addresses PR feedback about Task.ts getting too large

- Modified createSyntheticReadFileMessage to batch files in groups of 5 - Updated tests to verify single read_file call with multiple files - Added test for batching behavior when more than 5 files are mentioned - This improves efficiency by reducing the number of tool calls needed

MuriloFP · 2025-07-29T02:05:24Z

Changes Made

I've updated the synthetic message generation to use the multi-file read capability of the read_file tool:

Key Changes:

**Modified ** to batch files in groups of 5 (the maximum allowed by the read_file tool)
Updated tests to verify that multiple files are now read in a single tool call instead of separate calls
Added new test for batching behavior when more than 5 files are mentioned

Benefits:

More efficient handling of multiple file mentions
Reduces the number of tool calls needed
Aligns with how the read_file tool is designed to work (supporting up to 5 files per call)

Example:

When a user mentions 2 files like @file1.ts @file2.ts, instead of creating:

<read_file>...</read_file>
<read_file>...</read_file>

We now create:

<read_file>
<args>
  <file>
    <path>file1.ts</path>
  </file>
  <file>
    <path>file2.ts</path>
  </file>
</args>
</read_file>

All tests are passing ✅

MuriloFP · 2025-07-29T02:06:33Z

Changes Made

I've updated the synthetic message generation to use the multi-file read capability of the read_file tool:

Key Changes:

Modified createSyntheticReadFileMessage to batch files in groups of 5 (the maximum allowed by the read_file tool)
Updated tests to verify that multiple files are now read in a single tool call instead of separate calls
Added new test for batching behavior when more than 5 files are mentioned

Benefits:

More efficient handling of multiple file mentions
Reduces the number of tool calls needed
Aligns with how the read_file tool is designed to work (supporting up to 5 files per call)

Example:

When a user mentions 2 files like @file1.ts @file2.ts, instead of creating:

<read_file>...</read_file>
<read_file>...</read_file>

We now create:

<read_file>
<args>
  <file>
    <path>file1.ts</path>
  </file>
  <file>
    <path>file2.ts</path>
  </file>
</args>
</read_file>

All tests are passing ✅

daniel-lxs · 2025-07-31T15:49:03Z

This looks good! I only noticed 1 issue but that's probably because it's such a new feature:

When I mention an image the generated message tells Roo that it can't read images with the read_file tool, which might confuse the model because right now the read_file tool is able to read images, this might also be happening with other file types like .pdf.

It would be great if we can re utilize the logic on the readFileTool.ts file rather than implementing it again.

MuriloFP and others added 26 commits July 3, 2025 15:26

feat: add Issue Fixer Orchestrator mode

efaaed9

Merge branch 'RooCodeInc:main' into main

57d3fbe

Merge branch 'RooCodeInc:main' into main

ef61905

Merge branch 'RooCodeInc:main' into main

f5a51c4

Merge branch 'RooCodeInc:main' into main

bcbf329

Merge branch 'RooCodeInc:main' into main

80413c0

Merge branch 'RooCodeInc:main' into main

ab10140

Merge branch 'RooCodeInc:main' into main

39c5cf7

Merge branch 'RooCodeInc:main' into main

00a0b63

Merge branch 'RooCodeInc:main' into main

080b61b

Merge branch 'RooCodeInc:main' into main

7a5ad14

Merge branch 'RooCodeInc:main' into main

2c73ff2

Merge branch 'RooCodeInc:main' into main

05ccf57

Merge branch 'RooCodeInc:main' into main

fdb1f35

Merge branch 'RooCodeInc:main' into main

10ce509

Merge branch 'RooCodeInc:main' into main

ab1f9fc

Merge branch 'RooCodeInc:main' into main

74fd8b4

Merge branch 'RooCodeInc:main' into main

6745c8f

Merge branch 'RooCodeInc:main' into main

faf2ee5

Merge branch 'RooCodeInc:main' into main

b2dadf9

Merge branch 'RooCodeInc:main' into main

f648e4c

Merge branch 'RooCodeInc:main' into main

a6d1e60

Merge branch 'RooCodeInc:main' into main

be90907

Merge branch 'RooCodeInc:main' into main

ed3a077

Merge branch 'RooCodeInc:main' into main

856313f

MuriloFP requested review from cte, jr and mrubens as code owners July 24, 2025 19:35

github-project-automation bot added this to Roo Code Roadmap Jul 24, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jul 24, 2025

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 24, 2025

fix: update test mocks to fix CI failures

2eab16d

- Remove 'processed:' prefix from parseMentions mock - Update test expectations to match new behavior - Fix processUserContentMentions mock usage

KJ7LNW reviewed Jul 24, 2025

View reviewed changes

src/core/task/Task.ts Show resolved Hide resolved

MuriloFP marked this pull request as draft July 24, 2025 20:51

MuriloFP added 2 commits July 24, 2025 18:19

MuriloFP marked this pull request as ready for review July 24, 2025 21:55

daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 24, 2025

hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 24, 2025

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Changes Requested] in Roo Code Roadmap Jul 29, 2025

hannesrudolph added PR - Changes Requested and removed PR - Needs Preliminary Review labels Jul 29, 2025

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 29, 2025

MuriloFP moved this from PR [Changes Requested] to PR [Needs Prelim Review] in Roo Code Roadmap Jul 30, 2025

hannesrudolph added PR - Needs Preliminary Review and removed PR - Changes Requested labels Jul 30, 2025

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Changes Requested] in Roo Code Roadmap Jul 31, 2025

hannesrudolph added PR - Changes Requested and removed PR - Needs Preliminary Review labels Jul 31, 2025

hannesrudolph closed this Sep 23, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 23, 2025

github-project-automation bot moved this from PR [Changes Requested] to Done in Roo Code Roadmap Sep 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: resolve focus and performance issues with file mentions in first message (#4127) #6180

fix: resolve focus and performance issues with file mentions in first message (#4127) #6180

Uh oh!

MuriloFP commented Jul 24, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

KJ7LNW left a comment

Uh oh!

Uh oh!

MuriloFP commented Jul 29, 2025

Uh oh!

MuriloFP commented Jul 29, 2025

Uh oh!

daniel-lxs commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: resolve focus and performance issues with file mentions in first message (#4127) #6180

fix: resolve focus and performance issues with file mentions in first message (#4127) #6180

Uh oh!

Conversation

MuriloFP commented Jul 24, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related GitHub Issue

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

Uh oh!

KJ7LNW left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MuriloFP commented Jul 29, 2025

Changes Made

Key Changes:

Benefits:

Example:

Uh oh!

MuriloFP commented Jul 29, 2025

Changes Made

Key Changes:

Benefits:

Example:

Uh oh!

daniel-lxs commented Jul 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MuriloFP commented Jul 24, 2025 •

edited by ellipsis-dev bot

Loading